From b4d6a886fed3d025c7eae7ddc7249b3da2679eff Mon Sep 17 00:00:00 2001 From: Serraniel Date: Fri, 11 Sep 2020 19:33:34 +0200 Subject: [PATCH 1/3] #38 Fix innerHTML Warning when replacing Anime title --- src/javascript/enhancements/animeRequests.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/javascript/enhancements/animeRequests.js b/src/javascript/enhancements/animeRequests.js index 8bf5ade..82ba7a0 100644 --- a/src/javascript/enhancements/animeRequests.js +++ b/src/javascript/enhancements/animeRequests.js @@ -65,7 +65,10 @@ function removeUnknownUsers(node) { let profileData = upperDiv.innerHTML; // exchange data - upperDiv.innerHTML = `${anime}`; + let bElement = document.createElement('b'); + bElement.textContent = anime; + upperDiv.innerHTML = ``; + upperDiv.appendChild(bElement); // add user note if own request if (profileLink.length > 0) { From be721815deaa039c5003227785a30293b8afc756 Mon Sep 17 00:00:00 2001 From: Serraniel Date: Fri, 11 Sep 2020 20:36:38 +0200 Subject: [PATCH 2/3] #38 Fixed second innerHTML Warning --- src/javascript/enhancements/animeRequests.js | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/src/javascript/enhancements/animeRequests.js b/src/javascript/enhancements/animeRequests.js index 82ba7a0..108a83a 100644 --- a/src/javascript/enhancements/animeRequests.js +++ b/src/javascript/enhancements/animeRequests.js @@ -64,20 +64,26 @@ function removeUnknownUsers(node) { let anime = lowerDiv.innerText; let profileData = upperDiv.innerHTML; - // exchange data - let bElement = document.createElement('b'); - bElement.textContent = anime; - upperDiv.innerHTML = ``; - upperDiv.appendChild(bElement); - // add user note if own request if (profileLink.length > 0) { - lowerDiv.innerHTML = profileData; + let parser = new DOMParser(); + let parsedDocument = parser.parseFromString(profileData, 'text/html'); + + lowerDiv.innerHTML = ''; + while(parsedDocument.body.hasChildNodes()){ + lowerDiv.appendChild(parsedDocument.body.removeChild(parsedDocument.body.firstChild)); + } } // remove if foreign request. else { lowerDiv.innerHTML = ' '; } + + // exchange data + let bElement = document.createElement('b'); + bElement.textContent = anime; + upperDiv.innerHTML = ``; + upperDiv.appendChild(bElement); } if (node.tagName === targetTagName) { From ea67553c973f9803021a8353027418d0d490f707 Mon Sep 17 00:00:00 2001 From: Serraniel Date: Fri, 11 Sep 2020 20:37:08 +0200 Subject: [PATCH 3/3] #38 Added a comment --- src/javascript/enhancements/animeRequests.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/javascript/enhancements/animeRequests.js b/src/javascript/enhancements/animeRequests.js index 108a83a..05e21fe 100644 --- a/src/javascript/enhancements/animeRequests.js +++ b/src/javascript/enhancements/animeRequests.js @@ -66,6 +66,7 @@ function removeUnknownUsers(node) { // add user note if own request if (profileLink.length > 0) { + // Workaround to avoid innerHTML because of #38, see https://devtidbits.com/2017/12/06/quick-fix-the-unsafe_var_assignment-warning-in-javascript/ let parser = new DOMParser(); let parsedDocument = parser.parseFromString(profileData, 'text/html');