Serraniel/AniwatchPlus
Serraniel/AniwatchPlus
1
0
Fork 0
Code Issues 9 Pull requests 8 Packages Projects Releases 10 Wiki Activity

List dividers #107

New issue
Closed
opened 2020-11-04 20:14:34 +01:00 by Serraniel · 6 comments
Serraniel commented 2020-11-04 20:14:34 +01:00 (Migrated from github.com)
Copy link

Aniwatch introduced their own list dividers. The color is a bit different.

Aniwatch
image

Aniwatch Plus:
image

Aniwatch color overrides ours.

Additionally, they don´t add a divider line between the top element and the columns title. This and the fact they override the color currently results in a mix which is ugly with our divider on top of the first element and their dividers for the rest:
image

To discuss:

  • which color is better
  • should there be a dividers for the top element and column titles.
Aniwatch introduced their own list dividers. The color is a bit different. Aniwatch ![image](https://user-images.githubusercontent.com/8461282/98157664-f3aefc80-1ed9-11eb-9d46-6a9bb6d9e61c.png) Aniwatch Plus: ![image](https://user-images.githubusercontent.com/8461282/98157731-0c1f1700-1eda-11eb-99ac-5e5d61c6e83a.png) Aniwatch color overrides ours. Additionally, they don´t add a divider line between the top element and the columns title. This and the fact they override the color currently results in a mix which is ugly with our divider on top of the first element and their dividers for the rest: ![image](https://user-images.githubusercontent.com/8461282/98157879-4983a480-1eda-11eb-85f4-74961b7f4800.png) To discuss: * which color is better * should there be a dividers for the top element and column titles.
Serraniel commented 2020-11-04 20:20:45 +01:00 (Migrated from github.com)
Copy link

which color is better

Personally, I think the color we used is better because it is more decent and fits better to the websites background. The result is, that the effect of seperating the rows still exists but it is much less dirsturbing if you fastly scan the lines with your eyes.

should there be a dividers for the top element and column titles.

I don´t really have an oppinnion for this question tbh. I guess I prefer the version with that line as it operates as a separator the headlines.

> which color is better Personally, I think the color we used is better because it is more decent and fits better to the websites background. The result is, that the effect of seperating the rows still exists but it is much less dirsturbing if you fastly scan the lines with your eyes. > should there be a dividers for the top element and column titles. I don´t really have an oppinnion for this question tbh. I *guess* I prefer the version with that line as it operates as a separator the headlines.
Serraniel commented 2020-11-04 20:42:29 +01:00 (Migrated from github.com)
Copy link

Talking with @kaffem we decided to go with our version and fix the mixed borders only.

Talking with @kaffem we decided to go with our version and fix the mixed borders only.
Serraniel commented 2020-11-04 20:44:22 +01:00 (Migrated from github.com)
Copy link

Something else I noticed: The bottom border is merged in an ugly way with the left border. This affects our solution same as aniwatch original border.

image

If I find an easy fix for it, I will include it. Otherwhise I´ll create a follow up issue.

Something else I noticed: The bottom border is merged in an ugly way with the left border. This affects our solution same as aniwatch original border. ![image](https://user-images.githubusercontent.com/8461282/98160422-78037e80-1ede-11eb-898a-2513590b8850.png) If I find an easy fix for it, I will include it. Otherwhise I´ll create a follow up issue.
Serraniel commented 2020-11-04 20:54:31 +01:00 (Migrated from github.com)
Copy link

Something else I noticed: The bottom border is merged in an ugly way with the left border. This affects our solution same as aniwatch original border.

image

If I find an easy fix for it, I will include it. Otherwhise I´ll create a follow up issue.

Talking with iMostLiked we found two possible fixes:

  • using ::after instead of the border-bottom (we both disliked)
  • and as an alternative and even nicer fix (thanks to Gio): adding margin-bottom -1px.
> Something else I noticed: The bottom border is merged in an ugly way with the left border. This affects our solution same as aniwatch original border. > > ![image](https://user-images.githubusercontent.com/8461282/98160422-78037e80-1ede-11eb-898a-2513590b8850.png) > > If I find an easy fix for it, I will include it. Otherwhise I´ll create a follow up issue. Talking with iMostLiked we found two possible fixes: * using `::after` instead of the `border-bottom` (we both disliked) * and as an alternative and even nicer fix (thanks to Gio): adding `margin-bottom -1px`.
Serraniel commented 2020-11-04 21:11:04 +01:00 (Migrated from github.com)
Copy link

Update: Aniwatch fix for the border overlaps also fixes it for our border, so revoked last commit.

Update: Aniwatch fix for the border overlaps also fixes it for our border, so revoked last commit.
Serraniel commented 2020-11-04 21:34:27 +01:00 (Migrated from github.com)
Copy link

Fixed in 0.3.1

Fixed in 0.3.1
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
develop
dependabot/npm_and_yarn/develop/typescript-5.1.6
dependabot/npm_and_yarn/fast-xml-parser-and-is-svg-4.2.5
dependabot/npm_and_yarn/develop/cssnano-6.0.1
dependabot/npm_and_yarn/develop/del-7.0.0
dependabot/npm_and_yarn/develop/uuid-9.0.0
dependabot/npm_and_yarn/nth-check-and-gulp-imagemin-2.1.1
dependabot/npm_and_yarn/develop/color-4.2.3
dependabot/npm_and_yarn/develop/gulp-imagemin-8.0.0
feature/#152-switch-back-to-official-spacetime-package
feature/#61-import-from-mal-anilist-restructure-import-page
master
1.1.0.0
1.0.0.0
0.4.2.1-beta
0.4.1.0-beta
0.4.0.0-beta
0.3.1.0
0.3.0.0-beta
0.2.1.0-beta.0
0.2.0.0-beta.0
0.1.0.0-beta.0
Labels
Clear labels   
dependencies

Pull requests that update a dependency file

  
Priority: Critical

Critical issue.

  
Priority: High

High priority issue.

  
Priority: Low

Low priority issue.

  
Priority: Medium

Average priority issue.

  
State: Abandoned

Issue will not be implemented.

  
State: Blocked

Issue is blocked by another issue.

  
State: Completed

Issue has been fixed or implemented and version has been released.

  
State: In progress

Issue in development.

  
State: New

New items which hasn´t been sighted yet.

  
State: On Hold

Issue is currently on hold.

  
State: Pending

Item is pending for some reason.

  
State: Review needed

Issue needs to be reviewed.

  
State: Waiting for release

Issue is completed but there is no release version available yet.

  
Type: Bug

The issue describes a bug in the project.

  
Type: Enhancement

The issues describes a new feature or some other kind of enhancement for the project.

  
Type: Maintenance

The issue describes some kind of maintenance which has to be done for the project or repository.

  
Type: Question

The issue is a question.

No labels
dependencies
Priority: Critical
Priority: High
Priority: Low
Priority: Medium
State: Abandoned
State: Blocked
State: Completed
State: In progress
State: New
State: On Hold
State: Pending
State: Review needed
State: Waiting for release
Type: Bug
Type: Enhancement
Type: Maintenance
Type: Question
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Serraniel/AniwatchPlus#107
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?