Serraniel/AniwatchPlus
Serraniel/AniwatchPlus
1
0
Fork 0
Code Issues 9 Pull requests 8 Packages Projects Releases 10 Wiki Activity

#12 Fixed issue that last dropdown will pop in wrong position #17

Merged
Serraniel merged 1 commit from feature/#12-search-input-with-hotkey into develop 2020-08-04 11:23:58 +02:00
Conversation 3 Commits 1 Files changed 1 +4
Serraniel commented 2020-07-29 20:07:14 +02:00 (Migrated from github.com)
Copy link

This should fix the bug of last dropdown popping in wrong position from #12.

This should fix the bug of last dropdown popping in wrong position from #12.
Serraniel commented 2020-07-29 20:07:48 +02:00 (Migrated from github.com)
Copy link

This should fix your issue I think.

image

This should fix your issue I think. ![image](https://user-images.githubusercontent.com/8461282/88836561-29f02800-d1d7-11ea-85ce-d991750fa3b5.png)
kaffem commented 2020-07-29 21:02:27 +02:00 (Migrated from github.com)
Copy link

Yes, this does fix the issue; it's similiar to what I had.
menu.querySelectorAll('ul.dropdown').forEach(item => item.style.right = 'auto');

Yes, this does fix the issue; it's similiar to what I had. `menu.querySelectorAll('ul.dropdown').forEach(item => item.style.right = 'auto');`
Serraniel commented 2020-07-29 22:25:52 +02:00 (Migrated from github.com)
Copy link

I think I will keep it as it is for now to perform only necessary changes. The other dropdowns also should have right: auto by default.

I think I will keep it as it is for now to perform only necessary changes. The other dropdowns also should have `right: auto` by default.
kaffem (Migrated from github.com) approved these changes 2020-08-04 03:54:26 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
kaffem
Labels
Clear labels   
dependencies

Pull requests that update a dependency file

  
Priority: Critical

Critical issue.

  
Priority: High

High priority issue.

  
Priority: Low

Low priority issue.

  
Priority: Medium

Average priority issue.

  
State: Abandoned

Issue will not be implemented.

  
State: Blocked

Issue is blocked by another issue.

  
State: Completed

Issue has been fixed or implemented and version has been released.

  
State: In progress

Issue in development.

  
State: New

New items which hasn´t been sighted yet.

  
State: On Hold

Issue is currently on hold.

  
State: Pending

Item is pending for some reason.

  
State: Review needed

Issue needs to be reviewed.

  
State: Waiting for release

Issue is completed but there is no release version available yet.

  
Type: Bug

The issue describes a bug in the project.

  
Type: Enhancement

The issues describes a new feature or some other kind of enhancement for the project.

  
Type: Maintenance

The issue describes some kind of maintenance which has to be done for the project or repository.

  
Type: Question

The issue is a question.

No labels
dependencies
Priority: Critical
Priority: High
Priority: Low
Priority: Medium
State: Abandoned
State: Blocked
State: Completed
State: In progress
State: New
State: On Hold
State: Pending
State: Review needed
State: Waiting for release
Type: Bug
Type: Enhancement
Type: Maintenance
Type: Question
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Serraniel/AniwatchPlus#17
No description provided.
Delete branch "feature/#12-search-input-with-hotkey"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?