Serraniel/AniwatchPlus
Serraniel/AniwatchPlus
1
0
Fork 0
Code Issues 9 Pull requests 8 Packages Projects Releases 10 Wiki Activity

Feature/autoplay focus change #174

Merged
kaffem merged 4 commits from feature/autoplay-focus-change into develop 2021-02-08 18:30:26 +01:00
Conversation 0 Commits 4 Files changed 3 +44 -1
kaffem commented 2021-02-06 23:11:59 +01:00 (Migrated from github.com)
Copy link

PoC for #173

PoC for #173
Serraniel (Migrated from github.com) requested changes 2021-02-07 18:46:25 +01:00
Serraniel (Migrated from github.com) left a comment
Copy link

The rest looks fine to me. I like the decision to make the resume optional, too.

The rest looks fine to me. I like the decision to make the resume optional, too.
src/javascript/enhancements/anilyr.ts
Serraniel (Migrated from github.com) commented 2021-02-07 18:45:28 +01:00
Copy link

Maybe would rename it to indicate it's a Boolean. onSomething mostly is used for events or listeners.

let restartPlayerOnVisible: boolean;
Maybe would rename it to indicate it's a Boolean. `onSomething` mostly is used for events or listeners. ```suggestion let restartPlayerOnVisible: boolean; ```
kaffem (Migrated from github.com) reviewed 2021-02-08 06:05:54 +01:00
src/javascript/enhancements/anilyr.ts
kaffem (Migrated from github.com) commented 2021-02-08 06:05:54 +01:00
Copy link

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.
Serraniel (Migrated from github.com) approved these changes 2021-02-08 18:29:47 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Serraniel
Labels
Clear labels   
dependencies

Pull requests that update a dependency file

  
Priority: Critical

Critical issue.

  
Priority: High

High priority issue.

  
Priority: Low

Low priority issue.

  
Priority: Medium

Average priority issue.

  
State: Abandoned

Issue will not be implemented.

  
State: Blocked

Issue is blocked by another issue.

  
State: Completed

Issue has been fixed or implemented and version has been released.

  
State: In progress

Issue in development.

  
State: New

New items which hasn´t been sighted yet.

  
State: On Hold

Issue is currently on hold.

  
State: Pending

Item is pending for some reason.

  
State: Review needed

Issue needs to be reviewed.

  
State: Waiting for release

Issue is completed but there is no release version available yet.

  
Type: Bug

The issue describes a bug in the project.

  
Type: Enhancement

The issues describes a new feature or some other kind of enhancement for the project.

  
Type: Maintenance

The issue describes some kind of maintenance which has to be done for the project or repository.

  
Type: Question

The issue is a question.

No labels
dependencies
Priority: Critical
Priority: High
Priority: Low
Priority: Medium
State: Abandoned
State: Blocked
State: Completed
State: In progress
State: New
State: On Hold
State: Pending
State: Review needed
State: Waiting for release
Type: Bug
Type: Enhancement
Type: Maintenance
Type: Question
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Serraniel/AniwatchPlus#174
No description provided.
Delete branch "feature/autoplay-focus-change"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?