Serraniel/AniwatchPlus
Serraniel/AniwatchPlus
1
0
Fork 0
Code Issues 9 Pull requests 8 Packages Projects Releases 10 Wiki Activity

Feature/#161 autoscroll w2g #176

Merged
Serraniel merged 7 commits from feature/#161-autoscroll-w2g into develop 2021-02-13 21:42:24 +01:00
Conversation 5 Commits 7 Files changed 3 +52 -1
Serraniel commented 2021-02-08 19:44:41 +01:00 (Migrated from github.com)
Copy link

Some small examples:
large window non-scrollable result list:
https://user-images.githubusercontent.com/8461282/107266356-b1034000-6a45-11eb-9a28-5e8d06fdd3c3.mp4

large window all episodes seen:
https://user-images.githubusercontent.com/8461282/107266511-ee67cd80-6a45-11eb-87d7-155ff75c586e.mp4

large window scrollable result list:
https://user-images.githubusercontent.com/8461282/107266431-cd06e180-6a45-11eb-86d2-503873ea633d.mp4

large window very large result list:
https://user-images.githubusercontent.com/8461282/107266486-e314a200-6a45-11eb-895c-5f45a4c7b852.mp4

small window non-scrollable result list:
https://user-images.githubusercontent.com/8461282/107266584-03dcf780-6a46-11eb-9935-bd0c0da2ab96.mp4

small window scrollable result list:
https://user-images.githubusercontent.com/8461282/107266597-0a6b6f00-6a46-11eb-9fb8-6a525d37fa2e.mp4

Some small examples: large window non-scrollable result list: https://user-images.githubusercontent.com/8461282/107266356-b1034000-6a45-11eb-9a28-5e8d06fdd3c3.mp4 large window all episodes seen: https://user-images.githubusercontent.com/8461282/107266511-ee67cd80-6a45-11eb-87d7-155ff75c586e.mp4 large window scrollable result list: https://user-images.githubusercontent.com/8461282/107266431-cd06e180-6a45-11eb-86d2-503873ea633d.mp4 large window very large result list: https://user-images.githubusercontent.com/8461282/107266486-e314a200-6a45-11eb-895c-5f45a4c7b852.mp4 small window non-scrollable result list: https://user-images.githubusercontent.com/8461282/107266584-03dcf780-6a46-11eb-9935-bd0c0da2ab96.mp4 small window scrollable result list: https://user-images.githubusercontent.com/8461282/107266597-0a6b6f00-6a46-11eb-9fb8-6a525d37fa2e.mp4
Serraniel commented 2021-02-08 19:45:02 +01:00 (Migrated from github.com)
Copy link

I just will add us both as reviewers as we both worked on this now :P

I just will add us both as reviewers as we both worked on this now :P
Serraniel commented 2021-02-08 19:45:36 +01:00 (Migrated from github.com)
Copy link

I just will add us both as reviewers as we both worked on this now :P

Okay, I cannot set myself as reviewer....

> I just will add us both as reviewers as we both worked on this now :P Okay, I cannot set myself as reviewer....
Serraniel commented 2021-02-11 19:31:05 +01:00 (Migrated from github.com)
Copy link

To check:

  • clicking completed episodes in w2g
  • how often is the observer triggered
To check: - [x] clicking completed episodes in w2g - [x] how often is the observer triggered
Serraniel commented 2021-02-13 19:24:26 +01:00 (Migrated from github.com)
Copy link

To check:

  • clicking completed episodes in w2g
  • how often is the observer triggered

The first task has been fixed. As side effect the observer has been optimized so it is less triggered.

> To check: > > * [x] clicking completed episodes in w2g > * [x] how often is the observer triggered The first task has been fixed. As side effect the observer has been optimized so it is less triggered.
Serraniel commented 2021-02-13 20:26:41 +01:00 (Migrated from github.com)
Copy link

@kaffem ready for review 👋

@kaffem ready for review 👋
kaffem (Migrated from github.com) approved these changes 2021-02-13 21:29:26 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
kaffem
Labels
Clear labels   
dependencies

Pull requests that update a dependency file

  
Priority: Critical

Critical issue.

  
Priority: High

High priority issue.

  
Priority: Low

Low priority issue.

  
Priority: Medium

Average priority issue.

  
State: Abandoned

Issue will not be implemented.

  
State: Blocked

Issue is blocked by another issue.

  
State: Completed

Issue has been fixed or implemented and version has been released.

  
State: In progress

Issue in development.

  
State: New

New items which hasn´t been sighted yet.

  
State: On Hold

Issue is currently on hold.

  
State: Pending

Item is pending for some reason.

  
State: Review needed

Issue needs to be reviewed.

  
State: Waiting for release

Issue is completed but there is no release version available yet.

  
Type: Bug

The issue describes a bug in the project.

  
Type: Enhancement

The issues describes a new feature or some other kind of enhancement for the project.

  
Type: Maintenance

The issue describes some kind of maintenance which has to be done for the project or repository.

  
Type: Question

The issue is a question.

No labels
dependencies
Priority: Critical
Priority: High
Priority: Low
Priority: Medium
State: Abandoned
State: Blocked
State: Completed
State: In progress
State: New
State: On Hold
State: Pending
State: Review needed
State: Waiting for release
Type: Bug
Type: Enhancement
Type: Maintenance
Type: Question
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Serraniel/AniwatchPlus#176
No description provided.
Delete branch "feature/#161-autoscroll-w2g"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?