Better display of language icons #3
Labels
No labels
dependencies
Priority: Critical
Priority: High
Priority: Low
Priority: Medium
State: Abandoned
State: Blocked
State: Completed
State: In progress
State: New
State: On Hold
State: Pending
State: Review needed
State: Waiting for release
Type: Bug
Type: Enhancement
Type: Maintenance
Type: Question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Serraniel/AniwatchPlus#3
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Refined tasks:
Something else: Dub and sub icons are displayed close together without any relation to each other in the episode list. In the selection below an episode it is a bit random. in that example we have (scheme: dub (sub)):
I see what you did there: ordering by "seconday" (not jap) language with dub > sub.
Another idea for an rearrangement would be to put subs for the same dub below each other.
In episode list and episode lang selection, both would profit from that more matrix style display mode. the correlation from dub and sub is shown better and it offers more possibilites to combine dubs and subs (which may be interesting in the future if more languages will come).
(Those images are paint edits so please don´t blame me xd)
Regarding matrix mode of language buttons: As there currently only are Jap, Eng and Ger the "column" mode needs less space and looks more appealing in my oppinnion.
The display in the episode list probably has to be done in all three display modes:
Little addition to this: If there only is sub available, the audio language currently is completly missing on Aniwatch:
For a better consistency the Jap audio should be displayed, too.
@kaffem Do you think this kind of presentation is good with the thin vertical separators? It´s the same type of border we use for the horizontal separators in the list:
Yeah this looks good.
Boxed mode also is working now:
Additionally did major performance improvments to the algorithm while adding support for it 👌 .
Issue #58 has been created as successor for the realignment of the language selection below the player as it is a differnt at all and would blow up the pull request with additional code for a different feature.
Added with https://github.com/Serraniel/AniwatchPlus/releases/tag/0.2.0.0-beta.0