Serraniel/AniwatchPlus
Serraniel/AniwatchPlus
1
0
Fork 0
Code Issues 9 Pull requests 8 Projects Releases 10 Packages Wiki Activity

Feature/autoplay focus change #174

Merged
kaffem merged 4 commits from feature/autoplay-focus-change into develop 2021-02-08 18:30:26 +01:00
Conversation 0 Commits 4 Files changed 3 +3 -3
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit c06838b67f - Show all commits

6
src/javascript/enhancements/anilyr.ts
View file

@ -7,7 +7,7 @@ import * as helper from '../utils/helpers';
Serraniel commented 2021-02-07 18:45:28 +01:00 (Migrated from github.com)
Review
Copy link

Maybe would rename it to indicate it's a Boolean. onSomething mostly is used for events or listeners.

let restartPlayerOnVisible: boolean;
Maybe would rename it to indicate it's a Boolean. `onSomething` mostly is used for events or listeners. ```suggestion let restartPlayerOnVisible: boolean; ```
kaffem commented 2021-02-08 06:05:54 +01:00 (Migrated from github.com)
Review
Copy link

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.
Serraniel commented 2021-02-07 18:45:28 +01:00 (Migrated from github.com)
Review
Copy link

Maybe would rename it to indicate it's a Boolean. onSomething mostly is used for events or listeners.

let restartPlayerOnVisible: boolean;
Maybe would rename it to indicate it's a Boolean. `onSomething` mostly is used for events or listeners. ```suggestion let restartPlayerOnVisible: boolean; ```
kaffem commented 2021-02-08 06:05:54 +01:00 (Migrated from github.com)
Review
Copy link

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.
const SCREENSHOT_TOOLTIP_ID = 'anilyr-screenshots-tooltip'; const SCREENSHOT_TOOLTIP_ID = 'anilyr-screenshots-tooltip';
const PLAYER_ID = 'player'; const PLAYER_ID = 'player';
let onVisible: boolean; let resumePlayerOnVisible: boolean;
Serraniel commented 2021-02-07 18:45:28 +01:00 (Migrated from github.com)
Review
Copy link

Maybe would rename it to indicate it's a Boolean. onSomething mostly is used for events or listeners.

let restartPlayerOnVisible: boolean;
Maybe would rename it to indicate it's a Boolean. `onSomething` mostly is used for events or listeners. ```suggestion let restartPlayerOnVisible: boolean; ```
kaffem commented 2021-02-08 06:05:54 +01:00 (Migrated from github.com)
Review
Copy link

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.
Serraniel commented 2021-02-07 18:45:28 +01:00 (Migrated from github.com)
Review
Copy link

Maybe would rename it to indicate it's a Boolean. onSomething mostly is used for events or listeners.

let restartPlayerOnVisible: boolean;
Maybe would rename it to indicate it's a Boolean. `onSomething` mostly is used for events or listeners. ```suggestion let restartPlayerOnVisible: boolean; ```
kaffem commented 2021-02-08 06:05:54 +01:00 (Migrated from github.com)
Review
Copy link

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.
export function init(): void { export function init(): void {
getGlobalConfiguration().getProperty(SETTINGS_playerAutoplayAfterScreenshot, value => { getGlobalConfiguration().getProperty(SETTINGS_playerAutoplayAfterScreenshot, value => {
@ -30,7 +30,7 @@ export function init(): void {
Serraniel commented 2021-02-07 18:45:28 +01:00 (Migrated from github.com)
Review
Copy link

Maybe would rename it to indicate it's a Boolean. onSomething mostly is used for events or listeners.

let restartPlayerOnVisible: boolean;
Maybe would rename it to indicate it's a Boolean. `onSomething` mostly is used for events or listeners. ```suggestion let restartPlayerOnVisible: boolean; ```
kaffem commented 2021-02-08 06:05:54 +01:00 (Migrated from github.com)
Review
Copy link

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.
Serraniel commented 2021-02-07 18:45:28 +01:00 (Migrated from github.com)
Review
Copy link

Maybe would rename it to indicate it's a Boolean. onSomething mostly is used for events or listeners.

let restartPlayerOnVisible: boolean;
Maybe would rename it to indicate it's a Boolean. `onSomething` mostly is used for events or listeners. ```suggestion let restartPlayerOnVisible: boolean; ```
kaffem commented 2021-02-08 06:05:54 +01:00 (Migrated from github.com)
Review
Copy link

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.
}); });
getGlobalConfiguration().getProperty(SETTINGS_playerAutoplayAfterFocusGain, value => { getGlobalConfiguration().getProperty(SETTINGS_playerAutoplayAfterFocusGain, value => {
onVisible = value; resumePlayerOnVisible = value;
Serraniel commented 2021-02-07 18:45:28 +01:00 (Migrated from github.com)
Review
Copy link

Maybe would rename it to indicate it's a Boolean. onSomething mostly is used for events or listeners.

let restartPlayerOnVisible: boolean;
Maybe would rename it to indicate it's a Boolean. `onSomething` mostly is used for events or listeners. ```suggestion let restartPlayerOnVisible: boolean; ```
kaffem commented 2021-02-08 06:05:54 +01:00 (Migrated from github.com)
Review
Copy link

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.
Serraniel commented 2021-02-07 18:45:28 +01:00 (Migrated from github.com)
Review
Copy link

Maybe would rename it to indicate it's a Boolean. onSomething mostly is used for events or listeners.

let restartPlayerOnVisible: boolean;
Maybe would rename it to indicate it's a Boolean. `onSomething` mostly is used for events or listeners. ```suggestion let restartPlayerOnVisible: boolean; ```
kaffem commented 2021-02-08 06:05:54 +01:00 (Migrated from github.com)
Review
Copy link

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.
}); });
} }
@ -62,7 +62,7 @@ function observeTabFocus(): void {
Serraniel commented 2021-02-07 18:45:28 +01:00 (Migrated from github.com)
Review
Copy link

Maybe would rename it to indicate it's a Boolean. onSomething mostly is used for events or listeners.

let restartPlayerOnVisible: boolean;
Maybe would rename it to indicate it's a Boolean. `onSomething` mostly is used for events or listeners. ```suggestion let restartPlayerOnVisible: boolean; ```
kaffem commented 2021-02-08 06:05:54 +01:00 (Migrated from github.com)
Review
Copy link

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.
Serraniel commented 2021-02-07 18:45:28 +01:00 (Migrated from github.com)
Review
Copy link

Maybe would rename it to indicate it's a Boolean. onSomething mostly is used for events or listeners.

let restartPlayerOnVisible: boolean;
Maybe would rename it to indicate it's a Boolean. `onSomething` mostly is used for events or listeners. ```suggestion let restartPlayerOnVisible: boolean; ```
kaffem commented 2021-02-08 06:05:54 +01:00 (Migrated from github.com)
Review
Copy link

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.
pausePlayer(playerElement); pausePlayer(playerElement);
} }
} }
else if (docState === 'visible' && onVisible) { else if (docState === 'visible' && resumePlayerOnVisible) {
Serraniel commented 2021-02-07 18:45:28 +01:00 (Migrated from github.com)
Review
Copy link

Maybe would rename it to indicate it's a Boolean. onSomething mostly is used for events or listeners.

let restartPlayerOnVisible: boolean;
Maybe would rename it to indicate it's a Boolean. `onSomething` mostly is used for events or listeners. ```suggestion let restartPlayerOnVisible: boolean; ```
kaffem commented 2021-02-08 06:05:54 +01:00 (Migrated from github.com)
Review
Copy link

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.
Serraniel commented 2021-02-07 18:45:28 +01:00 (Migrated from github.com)
Review
Copy link

Maybe would rename it to indicate it's a Boolean. onSomething mostly is used for events or listeners.

let restartPlayerOnVisible: boolean;
Maybe would rename it to indicate it's a Boolean. `onSomething` mostly is used for events or listeners. ```suggestion let restartPlayerOnVisible: boolean; ```
kaffem commented 2021-02-08 06:05:54 +01:00 (Migrated from github.com)
Review
Copy link

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.
if (helper.assigned(playerElement)) { if (helper.assigned(playerElement)) {
resumePlayer(playerElement); resumePlayer(playerElement);
} }

Serraniel commented 2021-02-07 18:45:28 +01:00 (Migrated from github.com)
Review
Copy link

Maybe would rename it to indicate it's a Boolean. onSomething mostly is used for events or listeners.

let restartPlayerOnVisible: boolean;
Maybe would rename it to indicate it's a Boolean. `onSomething` mostly is used for events or listeners. ```suggestion let restartPlayerOnVisible: boolean; ```
kaffem commented 2021-02-08 06:05:54 +01:00 (Migrated from github.com)
Review
Copy link

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.
Serraniel commented 2021-02-07 18:45:28 +01:00 (Migrated from github.com)
Review
Copy link

Maybe would rename it to indicate it's a Boolean. onSomething mostly is used for events or listeners.

let restartPlayerOnVisible: boolean;
Maybe would rename it to indicate it's a Boolean. `onSomething` mostly is used for events or listeners. ```suggestion let restartPlayerOnVisible: boolean; ```
kaffem commented 2021-02-08 06:05:54 +01:00 (Migrated from github.com)
Review
Copy link

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.

I agree, instead of 'restart' I used 'resume' since it fits the overall functionality better.