Feature/#19 notifications tab title #31
|
@ -1,10 +1,21 @@
|
|||
>
>
> Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
> ![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
Yeah the 3 is the correct index here, your split is missing another space.
![chrome_8SQg6ZZOCH](https://user-images.githubusercontent.com/29717789/89420569-2eff2b00-d733-11ea-95e1-8735ac78c4eb.png)
Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether
> There probably also has to be a check if user is logged in and if there even is a notification I think.
9fe2668c3afec7a4b100cffc9ae722d1baa13fe7 adds checks for logged in + notifications
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think: There probably also has to be a check if user is logged in and if there even is a notification I think.
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
There probably also has to be a check if user is logged in and if there even is a notification I think.
You may try getting it via regular expression:
```js
menuDropdowns.querySelector('li a[href="notification"]')?.innerText?.match('\\d+')[0] ?? ''
```
We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert. We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert.
>
>
> Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
> ![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
Yeah the 3 is the correct index here, your split is missing another space.
![chrome_8SQg6ZZOCH](https://user-images.githubusercontent.com/29717789/89420569-2eff2b00-d733-11ea-95e1-8735ac78c4eb.png)
Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether
> There probably also has to be a check if user is logged in and if there even is a notification I think.
9fe2668c3afec7a4b100cffc9ae722d1baa13fe7 adds checks for logged in + notifications
|
||||
let __notificationCount = '';
|
||||
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think: There probably also has to be a check if user is logged in and if there even is a notification I think.
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
There probably also has to be a check if user is logged in and if there even is a notification I think.
You may try getting it via regular expression:
```js
menuDropdowns.querySelector('li a[href="notification"]')?.innerText?.match('\\d+')[0] ?? ''
```
We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert. We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert.
>
>
> Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
> ![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
Yeah the 3 is the correct index here, your split is missing another space.
![chrome_8SQg6ZZOCH](https://user-images.githubusercontent.com/29717789/89420569-2eff2b00-d733-11ea-95e1-8735ac78c4eb.png)
Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether
> There probably also has to be a check if user is logged in and if there even is a notification I think.
9fe2668c3afec7a4b100cffc9ae722d1baa13fe7 adds checks for logged in + notifications
|
||||
|
||||
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think: There probably also has to be a check if user is logged in and if there even is a notification I think.
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
There probably also has to be a check if user is logged in and if there even is a notification I think.
You may try getting it via regular expression:
```js
menuDropdowns.querySelector('li a[href="notification"]')?.innerText?.match('\\d+')[0] ?? ''
```
We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert. We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert.
>
>
> Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
> ![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
Yeah the 3 is the correct index here, your split is missing another space.
![chrome_8SQg6ZZOCH](https://user-images.githubusercontent.com/29717789/89420569-2eff2b00-d733-11ea-95e1-8735ac78c4eb.png)
Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether
> There probably also has to be a check if user is logged in and if there even is a notification I think.
9fe2668c3afec7a4b100cffc9ae722d1baa13fe7 adds checks for logged in + notifications
|
||||
runAfterLoad(() => {
|
||||
__notificationCount = getNotificationCount();
|
||||
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think: There probably also has to be a check if user is logged in and if there even is a notification I think.
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
There probably also has to be a check if user is logged in and if there even is a notification I think.
You may try getting it via regular expression:
```js
menuDropdowns.querySelector('li a[href="notification"]')?.innerText?.match('\\d+')[0] ?? ''
```
We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert. We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert.
>
>
> Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
> ![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
Yeah the 3 is the correct index here, your split is missing another space.
![chrome_8SQg6ZZOCH](https://user-images.githubusercontent.com/29717789/89420569-2eff2b00-d733-11ea-95e1-8735ac78c4eb.png)
Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether
> There probably also has to be a check if user is logged in and if there even is a notification I think.
9fe2668c3afec7a4b100cffc9ae722d1baa13fe7 adds checks for logged in + notifications
|
||||
displayNotificationsInTitle();
|
||||
}, ".*");
|
||||
|
||||
function displayNotificationsInTitle(){
|
||||
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think: There probably also has to be a check if user is logged in and if there even is a notification I think.
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
There probably also has to be a check if user is logged in and if there even is a notification I think.
You may try getting it via regular expression:
```js
menuDropdowns.querySelector('li a[href="notification"]')?.innerText?.match('\\d+')[0] ?? ''
```
We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert. We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert.
>
>
> Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
> ![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
Yeah the 3 is the correct index here, your split is missing another space.
![chrome_8SQg6ZZOCH](https://user-images.githubusercontent.com/29717789/89420569-2eff2b00-d733-11ea-95e1-8735ac78c4eb.png)
Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether
> There probably also has to be a check if user is logged in and if there even is a notification I think.
9fe2668c3afec7a4b100cffc9ae722d1baa13fe7 adds checks for logged in + notifications
|
||||
runAfterPathnameChange(() => {
|
||||
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think: There probably also has to be a check if user is logged in and if there even is a notification I think.
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
There probably also has to be a check if user is logged in and if there even is a notification I think.
You may try getting it via regular expression:
```js
menuDropdowns.querySelector('li a[href="notification"]')?.innerText?.match('\\d+')[0] ?? ''
```
We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert. We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert.
>
>
> Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
> ![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
Yeah the 3 is the correct index here, your split is missing another space.
![chrome_8SQg6ZZOCH](https://user-images.githubusercontent.com/29717789/89420569-2eff2b00-d733-11ea-95e1-8735ac78c4eb.png)
Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether
> There probably also has to be a check if user is logged in and if there even is a notification I think.
9fe2668c3afec7a4b100cffc9ae722d1baa13fe7 adds checks for logged in + notifications
|
||||
displayNotificationsInTitle();
|
||||
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think: There probably also has to be a check if user is logged in and if there even is a notification I think.
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
There probably also has to be a check if user is logged in and if there even is a notification I think.
You may try getting it via regular expression:
```js
menuDropdowns.querySelector('li a[href="notification"]')?.innerText?.match('\\d+')[0] ?? ''
```
We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert. We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert.
>
>
> Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
> ![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
Yeah the 3 is the correct index here, your split is missing another space.
![chrome_8SQg6ZZOCH](https://user-images.githubusercontent.com/29717789/89420569-2eff2b00-d733-11ea-95e1-8735ac78c4eb.png)
Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether
> There probably also has to be a check if user is logged in and if there even is a notification I think.
9fe2668c3afec7a4b100cffc9ae722d1baa13fe7 adds checks for logged in + notifications
|
||||
}, ".*");
|
||||
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think: There probably also has to be a check if user is logged in and if there even is a notification I think.
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
There probably also has to be a check if user is logged in and if there even is a notification I think.
You may try getting it via regular expression:
```js
menuDropdowns.querySelector('li a[href="notification"]')?.innerText?.match('\\d+')[0] ?? ''
```
We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert. We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert.
>
>
> Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
> ![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
Yeah the 3 is the correct index here, your split is missing another space.
![chrome_8SQg6ZZOCH](https://user-images.githubusercontent.com/29717789/89420569-2eff2b00-d733-11ea-95e1-8735ac78c4eb.png)
Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether
> There probably also has to be a check if user is logged in and if there even is a notification I think.
9fe2668c3afec7a4b100cffc9ae722d1baa13fe7 adds checks for logged in + notifications
|
||||
|
||||
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think: There probably also has to be a check if user is logged in and if there even is a notification I think.
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
There probably also has to be a check if user is logged in and if there even is a notification I think.
You may try getting it via regular expression:
```js
menuDropdowns.querySelector('li a[href="notification"]')?.innerText?.match('\\d+')[0] ?? ''
```
We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert. We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert.
>
>
> Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
> ![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
Yeah the 3 is the correct index here, your split is missing another space.
![chrome_8SQg6ZZOCH](https://user-images.githubusercontent.com/29717789/89420569-2eff2b00-d733-11ea-95e1-8735ac78c4eb.png)
Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether
> There probably also has to be a check if user is logged in and if there even is a notification I think.
9fe2668c3afec7a4b100cffc9ae722d1baa13fe7 adds checks for logged in + notifications
|
||||
function getNotificationCount() {
|
||||
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think: There probably also has to be a check if user is logged in and if there even is a notification I think.
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
There probably also has to be a check if user is logged in and if there even is a notification I think.
You may try getting it via regular expression:
```js
menuDropdowns.querySelector('li a[href="notification"]')?.innerText?.match('\\d+')[0] ?? ''
```
We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert. We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert.
>
>
> Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
> ![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
Yeah the 3 is the correct index here, your split is missing another space.
![chrome_8SQg6ZZOCH](https://user-images.githubusercontent.com/29717789/89420569-2eff2b00-d733-11ea-95e1-8735ac78c4eb.png)
Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether
> There probably also has to be a check if user is logged in and if there even is a notification I think.
9fe2668c3afec7a4b100cffc9ae722d1baa13fe7 adds checks for logged in + notifications
|
||||
let menu = document.getElementById('materialize-menu-dropdown');
|
||||
let menuDropdowns = Array.from(menu.querySelectorAll('ul.dropdown')).slice(-1)[0];
|
||||
let notificationText = menuDropdowns.innerText.split(" ")[3];
|
||||
document.title = notificationText.split(" ")[1] + ' ' + document.title;
|
||||
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think: There probably also has to be a check if user is logged in and if there even is a notification I think.
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
There probably also has to be a check if user is logged in and if there even is a notification I think.
You may try getting it via regular expression:
```js
menuDropdowns.querySelector('li a[href="notification"]')?.innerText?.match('\\d+')[0] ?? ''
```
We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert. We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert.
>
>
> Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
> ![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
Yeah the 3 is the correct index here, your split is missing another space.
![chrome_8SQg6ZZOCH](https://user-images.githubusercontent.com/29717789/89420569-2eff2b00-d733-11ea-95e1-8735ac78c4eb.png)
Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether
> There probably also has to be a check if user is logged in and if there even is a notification I think.
9fe2668c3afec7a4b100cffc9ae722d1baa13fe7 adds checks for logged in + notifications
|
||||
}
|
||||
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think: There probably also has to be a check if user is logged in and if there even is a notification I think.
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
There probably also has to be a check if user is logged in and if there even is a notification I think.
You may try getting it via regular expression:
```js
menuDropdowns.querySelector('li a[href="notification"]')?.innerText?.match('\\d+')[0] ?? ''
```
We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert. We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert.
>
>
> Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
> ![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
Yeah the 3 is the correct index here, your split is missing another space.
![chrome_8SQg6ZZOCH](https://user-images.githubusercontent.com/29717789/89420569-2eff2b00-d733-11ea-95e1-8735ac78c4eb.png)
Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether
> There probably also has to be a check if user is logged in and if there even is a notification I think.
9fe2668c3afec7a4b100cffc9ae722d1baa13fe7 adds checks for logged in + notifications
|
||||
return notificationText.split(" ")[1] + ' ';
|
||||
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think: There probably also has to be a check if user is logged in and if there even is a notification I think.
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
There probably also has to be a check if user is logged in and if there even is a notification I think.
You may try getting it via regular expression:
```js
menuDropdowns.querySelector('li a[href="notification"]')?.innerText?.match('\\d+')[0] ?? ''
```
We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert. We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert.
>
>
> Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
> ![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
Yeah the 3 is the correct index here, your split is missing another space.
![chrome_8SQg6ZZOCH](https://user-images.githubusercontent.com/29717789/89420569-2eff2b00-d733-11ea-95e1-8735ac78c4eb.png)
Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether
> There probably also has to be a check if user is logged in and if there even is a notification I think.
9fe2668c3afec7a4b100cffc9ae722d1baa13fe7 adds checks for logged in + notifications
|
||||
}
|
||||
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think: There probably also has to be a check if user is logged in and if there even is a notification I think.
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
There probably also has to be a check if user is logged in and if there even is a notification I think.
You may try getting it via regular expression:
```js
menuDropdowns.querySelector('li a[href="notification"]')?.innerText?.match('\\d+')[0] ?? ''
```
We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert. We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert.
>
>
> Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
> ![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
Yeah the 3 is the correct index here, your split is missing another space.
![chrome_8SQg6ZZOCH](https://user-images.githubusercontent.com/29717789/89420569-2eff2b00-d733-11ea-95e1-8735ac78c4eb.png)
Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether
> There probably also has to be a check if user is logged in and if there even is a notification I think.
9fe2668c3afec7a4b100cffc9ae722d1baa13fe7 adds checks for logged in + notifications
|
||||
|
||||
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think: There probably also has to be a check if user is logged in and if there even is a notification I think.
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
There probably also has to be a check if user is logged in and if there even is a notification I think.
You may try getting it via regular expression:
```js
menuDropdowns.querySelector('li a[href="notification"]')?.innerText?.match('\\d+')[0] ?? ''
```
We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert. We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert.
>
>
> Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
> ![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
Yeah the 3 is the correct index here, your split is missing another space.
![chrome_8SQg6ZZOCH](https://user-images.githubusercontent.com/29717789/89420569-2eff2b00-d733-11ea-95e1-8735ac78c4eb.png)
Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether
> There probably also has to be a check if user is logged in and if there even is a notification I think.
9fe2668c3afec7a4b100cffc9ae722d1baa13fe7 adds checks for logged in + notifications
|
||||
function displayNotificationsInTitle(){
|
||||
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think: There probably also has to be a check if user is logged in and if there even is a notification I think.
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
There probably also has to be a check if user is logged in and if there even is a notification I think.
You may try getting it via regular expression:
```js
menuDropdowns.querySelector('li a[href="notification"]')?.innerText?.match('\\d+')[0] ?? ''
```
We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert. We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert.
>
>
> Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
> ![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
Yeah the 3 is the correct index here, your split is missing another space.
![chrome_8SQg6ZZOCH](https://user-images.githubusercontent.com/29717789/89420569-2eff2b00-d733-11ea-95e1-8735ac78c4eb.png)
Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether
> There probably also has to be a check if user is logged in and if there even is a notification I think.
9fe2668c3afec7a4b100cffc9ae722d1baa13fe7 adds checks for logged in + notifications
|
||||
document.title = __notificationCount + document.title;
|
||||
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think: There probably also has to be a check if user is logged in and if there even is a notification I think.
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
There probably also has to be a check if user is logged in and if there even is a notification I think.
You may try getting it via regular expression:
```js
menuDropdowns.querySelector('li a[href="notification"]')?.innerText?.match('\\d+')[0] ?? ''
```
We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert. We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert.
>
>
> Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
> ![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
Yeah the 3 is the correct index here, your split is missing another space.
![chrome_8SQg6ZZOCH](https://user-images.githubusercontent.com/29717789/89420569-2eff2b00-d733-11ea-95e1-8735ac78c4eb.png)
Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether
> There probably also has to be a check if user is logged in and if there even is a notification I think.
9fe2668c3afec7a4b100cffc9ae722d1baa13fe7 adds checks for logged in + notifications
|
||||
}
|
||||
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think: There probably also has to be a check if user is logged in and if there even is a notification I think.
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
There probably also has to be a check if user is logged in and if there even is a notification I think.
You may try getting it via regular expression:
```js
menuDropdowns.querySelector('li a[href="notification"]')?.innerText?.match('\\d+')[0] ?? ''
```
We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert. We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert.
>
>
> Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
> ![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
Yeah the 3 is the correct index here, your split is missing another space.
![chrome_8SQg6ZZOCH](https://user-images.githubusercontent.com/29717789/89420569-2eff2b00-d733-11ea-95e1-8735ac78c4eb.png)
Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether
> There probably also has to be a check if user is logged in and if there even is a notification I think.
9fe2668c3afec7a4b100cffc9ae722d1baa13fe7 adds checks for logged in + notifications
|
||||
|
|
|||
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think: There probably also has to be a check if user is logged in and if there even is a notification I think.
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
There probably also has to be a check if user is logged in and if there even is a notification I think.
You may try getting it via regular expression:
```js
menuDropdowns.querySelector('li a[href="notification"]')?.innerText?.match('\\d+')[0] ?? ''
```
We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert. We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert.
>
>
> Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
> ![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
Yeah the 3 is the correct index here, your split is missing another space.
![chrome_8SQg6ZZOCH](https://user-images.githubusercontent.com/29717789/89420569-2eff2b00-d733-11ea-95e1-8735ac78c4eb.png)
Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether
> There probably also has to be a check if user is logged in and if there even is a notification I think.
9fe2668c3afec7a4b100cffc9ae722d1baa13fe7 adds checks for logged in + notifications
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think: There probably also has to be a check if user is logged in and if there even is a notification I think.
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
There probably also has to be a check if user is logged in and if there even is a notification I think.
You may try getting it via regular expression:
```js
menuDropdowns.querySelector('li a[href="notification"]')?.innerText?.match('\\d+')[0] ?? ''
```
We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert. We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert.
>
>
> Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
> ![image](https://user-images.githubusercontent.com/8461282/89397194-d5d1d000-d70f-11ea-804b-f4ca40b9c65d.png)
Yeah the 3 is the correct index here, your split is missing another space.
![chrome_8SQg6ZZOCH](https://user-images.githubusercontent.com/29717789/89420569-2eff2b00-d733-11ea-95e1-8735ac78c4eb.png)
Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether Right now there is a space added after the number in line 16; however I'll take a look into retrieving the notificationCount via regex since its not always working on pathnames like /watch2gether
> There probably also has to be a check if user is logged in and if there even is a notification I think.
9fe2668c3afec7a4b100cffc9ae722d1baa13fe7 adds checks for logged in + notifications
|
|
@ -1,5 +1,7 @@
|
|||
let __scripts = [];
|
||||
let __afterLoadScripts = [];
|
||||
let __afterPopstateScripts = [];
|
||||
let __afterPathnameChangeScripts = [];
|
||||
|
||||
function registerScript(func, pattern = '.*') {
|
||||
__scripts.push({ "function": func, "pattern": pattern });
|
||||
|
@ -51,4 +53,35 @@ function awaitPageLoaded() {
|
|||
})
|
||||
}
|
||||
}, 100);
|
||||
}
|
||||
}
|
||||
|
||||
function runAfterPathnameChange(func, pattern = '.*') {
|
||||
__afterPathnameChangeScripts.push({ "function": func, "pattern": pattern});
|
||||
}
|
||||
|
||||
let locationPath = location.pathname;
|
||||
let __loop = setInterval(() => {
|
||||
if (locationPath != location.pathname) {
|
||||
locationPath = location.pathname;
|
||||
awaitPathnameChange();
|
||||
}
|
||||
}, 100);
|
||||
|
||||
function awaitPathnameChange() {
|
||||
let preLoader = document.getElementById('preloader');
|
||||
|
||||
if (typeof preLoader === 'undefined') {
|
||||
return;
|
||||
}
|
||||
|
||||
let loop = setInterval(() => {
|
||||
if (preLoader.style.display === "none") {
|
||||
clearInterval(loop);
|
||||
__afterPathnameChangeScripts.forEach(script => {
|
||||
if (window.location.pathname.match(script.pattern)) {
|
||||
script.function();
|
||||
}
|
||||
})
|
||||
}
|
||||
}, 100);
|
||||
}
|
||||
|
|
Is 3 the correct index here? I just executed this via console and it wasn´t working correctly I think:
There probably also has to be a check if user is logged in and if there even is a notification I think.
You may try getting it via regular expression:
We should also insert a space after the number (at least the code I put in the other comment is without space). Also only add the space if there are notifications to insert.