Serraniel/DiscordMediaLoader
1
0
Fork 0
Code Issues 30 Pull requests 16 Packages Projects Releases 18 Wiki Activity

Merge pull request #23 from Serraniel/bugfix/#10-no-reprompt-on-wrong-login-data

Browse source 
Bugfix/#10 no reprompt on wrong login data
This commit is contained in:
Daniel 2019-01-30 20:48:07 +01:00 committed by GitHub
parent d773f7036d 224273d97b
commit b05e7e3965
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 29 additions and 50 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
DML.Client/DMLClient.cs
View file

@ -22,4 +22,4 @@ namespace DML.Client
return Client.LoginState == LoginState.LoggedIn && Client.ConnectionState == ConnectionState.Connected; return Client.LoginState == LoginState.LoggedIn && Client.ConnectionState == ConnectionState.Connected;
} }
} }
} }

77
Discord Media Loader.Application/Classes/Core.cs
View file

@ -1,11 +1,5 @@
using System; using Discord;
using System.Globalization; using Discord.Net;
using System.IO;
using System.Linq;
using System.Runtime;
using System.Threading.Tasks;
using System.Windows.Forms;
using Discord;
using Discord.WebSocket; using Discord.WebSocket;
using DML.AppCore.Classes; using DML.AppCore.Classes;
using DML.Application.Dialogs; using DML.Application.Dialogs;
@ -16,6 +10,13 @@ using SharpRaven.Data;
using SweetLib.Utils; using SweetLib.Utils;
using SweetLib.Utils.Logger; using SweetLib.Utils.Logger;
using SweetLib.Utils.Logger.Memory; using SweetLib.Utils.Logger.Memory;
using System;
using System.Globalization;
using System.IO;
using System.Linq;
using System.Runtime;
using System.Threading.Tasks;
using System.Windows.Forms;
using Logger = SweetLib.Utils.Logger.Logger; using Logger = SweetLib.Utils.Logger.Logger;
namespace DML.Application.Classes namespace DML.Application.Classes
@ -175,7 +176,6 @@ namespace DML.Application.Classes
Logger.Info("Trying to log into discord..."); Logger.Info("Trying to log into discord...");
var abort = false;
DMLClient.Client.Connected += Client_Connected; DMLClient.Client.Connected += Client_Connected;
@ -183,10 +183,19 @@ namespace DML.Application.Classes
while (!loggedIn) while (!loggedIn)
{ {
if (!string.IsNullOrEmpty(Settings.LoginToken)) var token = "abc";
try
{ {
Logger.Debug("Trying to login with last known token..."); if (!string.IsNullOrEmpty(Settings.LoginToken))
loggedIn = await DMLClient.Login(Settings.LoginToken); {
Logger.Debug("Trying to login with last known token...");
loggedIn = await DMLClient.Login(token);
}
}
catch (HttpException e)
{
Logger.Warn("HTTPException occured during login. Probably from login token.");
} }
if (!loggedIn) if (!loggedIn)
@ -197,42 +206,6 @@ namespace DML.Application.Classes
} }
} }
/*while ((Client.LoginState != LoginState.LoggedIn || Client.ConnectionState!=ConnectionState.Connected) && !abort)
{
Logger.Debug(Client.ConnectionState.ToString());
Logger.Debug(Client.LoginState.ToString());
Logger.Trace("Entering login loop.");
try
{
if (Client.ConnectionState == ConnectionState.Connecting)
continue;
if (!string.IsNullOrEmpty(Settings.LoginToken))
{
Logger.Debug("Trying to login with last known token...");
await Client.LoginAsync(TokenType.User, Settings.LoginToken);
await Client.StartAsync();
await Task.Delay(1000);
}
}
catch (HttpException ex)
{
Logger.Warn($"Login seems to have failed or gone wrong: {ex.GetType().Name} - {ex.Message}");
}
if (Client.LoginState == LoginState.LoggedOut)
{
Settings.Password = string.Empty;
Logger.Debug("Showing dialog for username and password...");
var loginDlg = new LoginDialog();
loginDlg.ShowDialog();
Logger.Trace("Dialog closed.");
}
}*/
Logger.Debug("Start checking for invalid jobs..."); Logger.Debug("Start checking for invalid jobs...");
//Client //Client
@ -248,12 +221,16 @@ namespace DML.Application.Classes
var isError = false; var isError = false;
var guild = FindServerById(job.GuildId); var guild = FindServerById(job.GuildId);
if (guild == null) if (guild == null)
{
isError = true; isError = true;
}
else else
{ {
var channel = FindChannelById(guild, job.ChannelId); var channel = FindChannelById(guild, job.ChannelId);
if (channel == null) if (channel == null)
{
isError = true; isError = true;
}
} }
if (isError) if (isError)
@ -280,9 +257,11 @@ namespace DML.Application.Classes
} }
catch (Exception ex) catch (Exception ex)
{ {
Logger.Error($"{ex.Message} occured at: {ex.StackTrace}"); Logger.Error($"{ex.Message} [{ex.GetType().Name}] occured at: {ex.StackTrace}");
if (MessageBox.Show($"An error occured while running Discord Media Loader:\n{ex.GetType().Name}: {ex.Message}\n\nDo you aggree to sending the error report to the creator of the tool?", "Discord Media Loader", MessageBoxButtons.YesNo) == DialogResult.Yes) if (MessageBox.Show($"An error occured while running Discord Media Loader:\n{ex.GetType().Name}: {ex.Message}\n\nDo you aggree to sending the error report to the creator of the tool?", "Discord Media Loader", MessageBoxButtons.YesNo) == DialogResult.Yes)
{
Raven.Capture(new SentryEvent(ex)); Raven.Capture(new SentryEvent(ex));
}
} }
} }