Serraniel/AniwatchPlus
Serraniel/AniwatchPlus
1
0
Fork 0
Code Issues 9 Pull requests 8 Packages Projects Releases 10 Wiki Activity

Merge pull request #45 from Serraniel/bugfix/#38-unsafe-assignment-to-innerhtml

Browse source 
Bugfix/#38 unsafe assignment to innerhtml
This commit is contained in:
kaffem 2020-09-14 01:01:14 +02:00 committed by GitHub
parent df369b93de ea67553c97
commit ca6d597da6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/javascript/enhancements/animeRequests.js
View file

@ -64,17 +64,27 @@ function removeUnknownUsers(node) {
let anime = lowerDiv.innerText;
let profileData = upperDiv.innerHTML;
// exchange data
upperDiv.innerHTML = `<b>${anime}</b>`;
// add user note if own request
if (profileLink.length > 0) {
lowerDiv.innerHTML = profileData;
// Workaround to avoid innerHTML because of #38, see https://devtidbits.com/2017/12/06/quick-fix-the-unsafe_var_assignment-warning-in-javascript/
let parser = new DOMParser();
let parsedDocument = parser.parseFromString(profileData, 'text/html');
lowerDiv.innerHTML = '';
while(parsedDocument.body.hasChildNodes()){
lowerDiv.appendChild(parsedDocument.body.removeChild(parsedDocument.body.firstChild));
}
}
// remove if foreign request.
else {
lowerDiv.innerHTML = '&nbsp;';
}
// exchange data
let bElement = document.createElement('b');
bElement.textContent = anime;
upperDiv.innerHTML = ``;
upperDiv.appendChild(bElement);
}
if (node.tagName === targetTagName) {