Serraniel/AniwatchPlus
Serraniel/AniwatchPlus
1
0
Fork 0
Code Issues 9 Pull requests 8 Packages Projects Releases 10 Wiki Activity

Feature/#48 migrate to typescript #151

Merged
Serraniel merged 30 commits from feature/#48-migrate-to-typescript into develop 2020-12-30 17:24:49 +01:00
Conversation 4 Commits 30 Files changed 22 +533 -318
Serraniel commented 2020-12-28 23:36:24 +01:00 (Migrated from github.com)
Copy link
No description provided.
Serraniel (Migrated from github.com) reviewed 2020-12-28 23:39:51 +01:00
src/javascript/browserApi/storageProvider.ts
@ -0,0 +64,4 @@
}
});
}
Serraniel (Migrated from github.com) commented 2020-12-28 23:38:13 +01:00
Copy link
  • Check Todo
- [x] Check Todo
src/javascript/configuration/configuration.ts
@ -0,0 +12,4 @@
export const SETTINGS_animeLanguageDisplay = 'animeLanguageDisplay';
// requests
export const SETTINGS_requestBeautifyPage = 'requestBeautifyPage';
// player
Serraniel (Migrated from github.com) commented 2020-12-28 23:38:47 +01:00
Copy link
            // TODO see comment
```suggestion // TODO see comment ```
Serraniel (Migrated from github.com) commented 2020-12-28 23:38:58 +01:00
Copy link
  • Check Todo
- [ ] Check Todo
src/javascript/enhancements/fontColor.ts
@ -0,0 +48,4 @@
if (__observedBadges.indexOf(badge) >= 0) {
return;
}
Serraniel (Migrated from github.com) commented 2020-12-28 23:39:33 +01:00
Copy link
  • Check Todo
- [x] Check Todo
Serraniel commented 2020-12-28 23:44:13 +01:00 (Migrated from github.com)
Copy link
  • When #150 is merged, this also has to be migrated to typescript.
- [x] When #150 is merged, this also has to be migrated to typescript.
Serraniel commented 2020-12-28 23:45:31 +01:00 (Migrated from github.com)
Copy link
  • Features have to be tested in chromium based browsers
  • Features have to be tested in firefox
- [x] Features have to be tested in chromium based browsers - [x] Features have to be tested in firefox
Serraniel commented 2020-12-28 23:45:35 +01:00 (Migrated from github.com)
Copy link

@kaffem You may also check if you see any obvious mistakes. I´ll look into the open tasks the next days. Also the changes are completly untested yet.

@kaffem You may also check if you see any obvious mistakes. I´ll look into the open tasks the next days. Also the changes are completly untested yet.
Serraniel (Migrated from github.com) reviewed 2020-12-29 15:33:00 +01:00
src/javascript/browserApi/storageProvider.ts
@ -0,0 +64,4 @@
}
});
}
Serraniel (Migrated from github.com) commented 2020-12-29 15:33:00 +01:00
Copy link

This may be used as an alternative and maybe better implementation:
https://stackoverflow.com/a/45985333

This may be used as an alternative and maybe better implementation: https://stackoverflow.com/a/45985333
Serraniel (Migrated from github.com) reviewed 2020-12-29 15:34:01 +01:00
src/javascript/configuration/configuration.ts
@ -0,0 +12,4 @@
export const SETTINGS_animeLanguageDisplay = 'animeLanguageDisplay';
// requests
export const SETTINGS_requestBeautifyPage = 'requestBeautifyPage';
// player
Serraniel (Migrated from github.com) commented 2020-12-29 15:34:01 +01:00
Copy link
  • Check todo
- [x] Check todo
Serraniel commented 2020-12-29 18:54:02 +01:00 (Migrated from github.com)
Copy link
  • Features have to be tested in chromium based browsers
  • Features have to be tested in firefox

I decided it works 👀

> * [x] Features have to be tested in chromium based browsers > * [x] Features have to be tested in firefox I decided it works 👀
kaffem (Migrated from github.com) approved these changes 2020-12-29 19:31:33 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
kaffem
Labels
Clear labels   
dependencies

Pull requests that update a dependency file

  
Priority: Critical

Critical issue.

  
Priority: High

High priority issue.

  
Priority: Low

Low priority issue.

  
Priority: Medium

Average priority issue.

  
State: Abandoned

Issue will not be implemented.

  
State: Blocked

Issue is blocked by another issue.

  
State: Completed

Issue has been fixed or implemented and version has been released.

  
State: In progress

Issue in development.

  
State: New

New items which hasn´t been sighted yet.

  
State: On Hold

Issue is currently on hold.

  
State: Pending

Item is pending for some reason.

  
State: Review needed

Issue needs to be reviewed.

  
State: Waiting for release

Issue is completed but there is no release version available yet.

  
Type: Bug

The issue describes a bug in the project.

  
Type: Enhancement

The issues describes a new feature or some other kind of enhancement for the project.

  
Type: Maintenance

The issue describes some kind of maintenance which has to be done for the project or repository.

  
Type: Question

The issue is a question.

No labels
dependencies
Priority: Critical
Priority: High
Priority: Low
Priority: Medium
State: Abandoned
State: Blocked
State: Completed
State: In progress
State: New
State: On Hold
State: Pending
State: Review needed
State: Waiting for release
Type: Bug
Type: Enhancement
Type: Maintenance
Type: Question
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Serraniel/AniwatchPlus#151
No description provided.
Delete branch "feature/#48-migrate-to-typescript"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?