Feature/#48 migrate to typescript #151

Merged
Serraniel merged 30 commits from feature/#48-migrate-to-typescript into develop 2020-12-30 17:24:49 +01:00
Serraniel commented 2020-12-28 23:36:24 +01:00 (Migrated from github.com)
No description provided.
Serraniel (Migrated from github.com) reviewed 2020-12-28 23:39:51 +01:00
@ -0,0 +64,4 @@
}
});
}
Serraniel (Migrated from github.com) commented 2020-12-28 23:38:13 +01:00
  • Check Todo
- [x] Check Todo
@ -0,0 +12,4 @@
export const SETTINGS_animeLanguageDisplay = 'animeLanguageDisplay';
// requests
export const SETTINGS_requestBeautifyPage = 'requestBeautifyPage';
// player
Serraniel (Migrated from github.com) commented 2020-12-28 23:38:47 +01:00
            // TODO see comment
```suggestion // TODO see comment ```
Serraniel (Migrated from github.com) commented 2020-12-28 23:38:58 +01:00
  • Check Todo
- [ ] Check Todo
@ -0,0 +48,4 @@
if (__observedBadges.indexOf(badge) >= 0) {
return;
}
Serraniel (Migrated from github.com) commented 2020-12-28 23:39:33 +01:00
  • Check Todo
- [x] Check Todo
Serraniel commented 2020-12-28 23:44:13 +01:00 (Migrated from github.com)
  • When #150 is merged, this also has to be migrated to typescript.
- [x] When #150 is merged, this also has to be migrated to typescript.
Serraniel commented 2020-12-28 23:45:31 +01:00 (Migrated from github.com)
  • Features have to be tested in chromium based browsers
  • Features have to be tested in firefox
- [x] Features have to be tested in chromium based browsers - [x] Features have to be tested in firefox
Serraniel commented 2020-12-28 23:45:35 +01:00 (Migrated from github.com)

@kaffem You may also check if you see any obvious mistakes. I´ll look into the open tasks the next days. Also the changes are completly untested yet.

@kaffem You may also check if you see any obvious mistakes. I´ll look into the open tasks the next days. Also the changes are completly untested yet.
Serraniel (Migrated from github.com) reviewed 2020-12-29 15:33:00 +01:00
@ -0,0 +64,4 @@
}
});
}
Serraniel (Migrated from github.com) commented 2020-12-29 15:33:00 +01:00

This may be used as an alternative and maybe better implementation:
https://stackoverflow.com/a/45985333

This may be used as an alternative and maybe better implementation: https://stackoverflow.com/a/45985333
Serraniel (Migrated from github.com) reviewed 2020-12-29 15:34:01 +01:00
@ -0,0 +12,4 @@
export const SETTINGS_animeLanguageDisplay = 'animeLanguageDisplay';
// requests
export const SETTINGS_requestBeautifyPage = 'requestBeautifyPage';
// player
Serraniel (Migrated from github.com) commented 2020-12-29 15:34:01 +01:00
  • Check todo
- [x] Check todo
Serraniel commented 2020-12-29 18:54:02 +01:00 (Migrated from github.com)
  • Features have to be tested in chromium based browsers
  • Features have to be tested in firefox

I decided it works 👀

> * [x] Features have to be tested in chromium based browsers > * [x] Features have to be tested in firefox I decided it works 👀
kaffem (Migrated from github.com) approved these changes 2020-12-29 19:31:33 +01:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Serraniel/AniwatchPlus#151
No description provided.