Feature/#32 option menu #112

2020-11-07T18:55:12+01:00

Serraniel commented

2020-11-07 18:55:12 +01:00

(Migrated from github.com)

Firefox is missing

But the rest of the changes is ready for review I think.

- [x] Firefox is missing But the rest of the changes is ready for review I think.

Serraniel commented

2020-11-08 13:03:16 +01:00

(Migrated from github.com)

I added an implementation for firefox but it´s a bit of a nightmare to validate it, as you cannot use the sync storage with a temporary addon. It will give the following error:

Uncaught (in promise) Error: The storage API will not work with a temporary addon ID. Please add an explicit addon ID to your manifest. For more information see https://bugzil.la/1323228.

However, I validated the code itself is working by just using the local storage instead of sync storage.

Additionally I found out, that the chrome local storage api also is working in firefox. Just as a side fact.

I added an implementation for firefox but it´s a bit of a nightmare to validate it, as you cannot use the sync storage with a temporary addon. It will give the following error: > Uncaught (in promise) Error: The storage API will not work with a temporary addon ID. Please add an explicit addon ID to your manifest. For more information see https://bugzil.la/1323228. However, I validated the code itself is working by just using the local storage instead of sync storage. Additionally I found out, that the chrome local storage api also is working in firefox. Just as a side fact.

Serraniel commented

2020-11-08 13:13:42 +01:00

(Migrated from github.com)

I think that´s it. Also decided to not open settings in tab, so the browser show that kind of overlay which should be enough imo and saves us from further styiling.

I think that´s it. Also decided to not open settings in tab, so the browser show that kind of overlay which should be enough imo and saves us from further styiling. ![201108_13-13-22-518 Erweiterungen_-_Aniwatch_Plus_-_Google_Chrome](https://user-images.githubusercontent.com/8461282/98464553-09ffd580-21c4-11eb-9ef6-9824d61f7036.png)![201108_13-13-35-339 Erweiterungen_-_Aniwatch_Plus_-_Google_Chrome](https://user-images.githubusercontent.com/8461282/98464558-0bc99900-21c4-11eb-9f93-3c79751c55a7.png)

Serraniel (Migrated from github.com) reviewed 2020-11-08 13:20:32 +01:00

src/javascript/configuration/configuration.js

					
				@ -0,0 +24,4 @@

				            callback(this.settingsCache.get(key));

				        }

				        else {

				            // OOOPS // currently all settings are default true. This isn´t a problem but there should be much better soloutions after migration to typescript....