Serraniel/AniwatchPlus
Serraniel/AniwatchPlus
1
0
Fork 0
Code Issues 9 Pull requests 8 Packages Projects Releases 10 Wiki Activity

Feature/#32 option menu #112

Merged
Serraniel merged 31 commits from feature/#32-option-menu into develop 2020-11-09 17:28:43 +01:00
Conversation 2 Commits 31 Files changed 21 +3 -3
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 483ea7f96e - Show all commits

2
src/javascript/browserApi/storageProvider.js
View file

@ -61,7 +61,7 @@ class StorageProviderFirefox {
} }
} }
let __storageProvieder = undefined; let __storageProvieder;
function createStorageProvider() { function createStorageProvider() {
// chrome based browser // chrome based browser

4
src/javascript/configuration/configuration.js
View file

@ -25,7 +25,7 @@ class Configuration {
} }
else { else {
// OOOPS // currently all settings are default true. This isn´t a problem but there should be much better soloutions after migration to typescript.... // OOOPS // currently all settings are default true. This isn´t a problem but there should be much better soloutions after migration to typescript....
Serraniel commented 2020-11-08 13:20:31 +01:00 (Migrated from github.com)
Review
Copy link

This should be refactored and improved after #48 .

This should be refactored and improved after #48 .
let value = getGlobalStorageProvider().getData(key, true, value => { getGlobalStorageProvider().getData(key, true, value => {
this.settingsCache.set(key, value); this.settingsCache.set(key, value);
callback(value); callback(value);
}); });
@ -33,7 +33,7 @@ class Configuration {
} }
} }
let __globalConfig = undefined; let __globalConfig;
export function getGlobalConfiguration() { export function getGlobalConfiguration() {
if (!assigned(__globalConfig)) { if (!assigned(__globalConfig)) {