Serraniel/AniwatchPlus
Serraniel/AniwatchPlus
1
0
Fork 0
Code Issues 9 Pull requests 8 Packages Projects Releases 10 Wiki Activity

Feature/#35 build tools #36

Merged
Serraniel merged 41 commits from feature/#35-build-tools into develop 2020-09-06 21:20:03 +02:00
Conversation 0 Commits 41 Files changed 23 +12021 -99
Serraniel commented 2020-08-26 22:03:43 +02:00 (Migrated from github.com)
Copy link

This introduces automatic bundling of the sources and creating the plugins for all browsers. Requires npm and gulp.

Todos

  • documentation
  • enhancement scripts are run at document_start. This results in runAfterLoad being broken now
  • personal review of those changes because I don´t trust myself :D
This introduces automatic bundling of the sources and creating the plugins for all browsers. Requires npm and gulp. Todos - [x] documentation - [x] enhancement scripts are run at `document_start`. This results in `runAfterLoad` being broken now - [x] personal review of those changes because I don´t trust myself :D
Serraniel (Migrated from github.com) reviewed 2020-08-29 17:31:48 +02:00
README.md
@ -3,0 +20,4 @@
### Tools
This project requires you to install [NPM](https://nodejs.org/en/download/) and [gulp](https://www.npmjs.com/package/gulp).
### Build
Serraniel (Migrated from github.com) commented 2020-08-29 17:30:19 +02:00
Copy link

Maybe would be nice if you could try to get the scripts from readme.md running with little docs I wrote @kaffem .

Maybe would be nice if you could try to get the scripts from readme.md running with little docs I wrote @kaffem .
package.json
Serraniel (Migrated from github.com) commented 2020-08-29 17:31:34 +02:00
Copy link

Also feel free to add yourself here any time you like, see https://docs.npmjs.com/files/package.json#people-fields-author-contributors.

Also feel free to add yourself here any time you like, see https://docs.npmjs.com/files/package.json#people-fields-author-contributors.
kaffem (Migrated from github.com) reviewed 2020-09-01 16:01:08 +02:00
README.md
@ -3,0 +20,4 @@
### Tools
This project requires you to install [NPM](https://nodejs.org/en/download/) and [gulp](https://www.npmjs.com/package/gulp).
### Build
kaffem (Migrated from github.com) commented 2020-09-01 16:00:13 +02:00
Copy link

The scripts appear to be working correctly.

The scripts appear to be working correctly.
src/manifests/firefox.manifest.json
kaffem (Migrated from github.com) commented 2020-09-01 16:00:54 +02:00
Copy link

This needs to be an object for firefox, see devDocs/manifest.json/developer otherwise it's an invalid extension.

This needs to be an object for firefox, see [devDocs/manifest.json/developer](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/developer) otherwise it's an invalid extension.
Serraniel (Migrated from github.com) reviewed 2020-09-02 15:00:20 +02:00
src/manifests/firefox.manifest.json
Serraniel (Migrated from github.com) commented 2020-09-02 15:00:19 +02:00
Copy link

Yeah you are correct. Somehow forgot to change this but I read it, too.

Yeah you are correct. Somehow forgot to change this but I read it, too.
Serraniel (Migrated from github.com) reviewed 2020-09-04 16:08:00 +02:00
gulpfile.js
Serraniel (Migrated from github.com) commented 2020-09-04 16:08:00 +02:00
Copy link
        debug: isDev
```suggestion debug: isDev ```
Serraniel (Migrated from github.com) reviewed 2020-09-06 20:58:57 +02:00
src/manifests/firefox.manifest.json
Serraniel (Migrated from github.com) commented 2020-09-06 20:58:57 +02:00
Copy link

This is fixed. Manifest validation on the webstores also is working now (regarding manifest.json syntax). I will open new issues for other validation problems I noticed.

This is fixed. Manifest validation on the webstores also is working now (regarding *manifest.json* syntax). I will open new issues for other validation problems I noticed.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
dependencies

Pull requests that update a dependency file

  
Priority: Critical

Critical issue.

  
Priority: High

High priority issue.

  
Priority: Low

Low priority issue.

  
Priority: Medium

Average priority issue.

  
State: Abandoned

Issue will not be implemented.

  
State: Blocked

Issue is blocked by another issue.

  
State: Completed

Issue has been fixed or implemented and version has been released.

  
State: In progress

Issue in development.

  
State: New

New items which hasn´t been sighted yet.

  
State: On Hold

Issue is currently on hold.

  
State: Pending

Item is pending for some reason.

  
State: Review needed

Issue needs to be reviewed.

  
State: Waiting for release

Issue is completed but there is no release version available yet.

  
Type: Bug

The issue describes a bug in the project.

  
Type: Enhancement

The issues describes a new feature or some other kind of enhancement for the project.

  
Type: Maintenance

The issue describes some kind of maintenance which has to be done for the project or repository.

  
Type: Question

The issue is a question.

No labels
dependencies
Priority: Critical
Priority: High
Priority: Low
Priority: Medium
State: Abandoned
State: Blocked
State: Completed
State: In progress
State: New
State: On Hold
State: Pending
State: Review needed
State: Waiting for release
Type: Bug
Type: Enhancement
Type: Maintenance
Type: Question
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Serraniel/AniwatchPlus#36
No description provided.
Delete branch "feature/#35-build-tools"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?