Serraniel/AniwatchPlus
Serraniel/AniwatchPlus
1
0
Fork 0
Code Issues 9 Pull requests 8 Packages Projects Releases 10 Wiki Activity

Feature/#35 build tools #36

Merged
Serraniel merged 41 commits from feature/#35-build-tools into develop 2020-09-06 21:20:03 +02:00
Conversation 0 Commits 41 Files changed 23 +3 -3
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 91af8850b8 - Show all commits

2
gulpfile.js
View file

@ -155,7 +155,7 @@ gulp.task('manifests', () => {
Serraniel commented 2020-09-04 16:08:00 +02:00 (Migrated from github.com)
Review
Copy link
        debug: isDev
```suggestion debug: isDev ```
Serraniel commented 2020-09-04 16:08:00 +02:00 (Migrated from github.com)
Review
Copy link
        debug: isDev
```suggestion debug: isDev ```
.pipe($.replace('$semanticVersion', template.version_name))
.pipe($.replace('$description', template.description))
.pipe($.replace('$author', template.author))
.pipe($.replace('$developer', template.developer))
Serraniel commented 2020-09-04 16:08:00 +02:00 (Migrated from github.com)
Review
Copy link
        debug: isDev
```suggestion debug: isDev ```
.pipe($.replace('$developer', JSON.stringify(template.developer)))
Serraniel commented 2020-09-04 16:08:00 +02:00 (Migrated from github.com)
Review
Copy link
        debug: isDev
```suggestion debug: isDev ```
.pipe($.replace('$homepageURL', template.homepage_url))
.pipe($.size({
showFiles: true,

Serraniel commented 2020-09-04 16:08:00 +02:00 (Migrated from github.com)
Review
Copy link
        debug: isDev
```suggestion debug: isDev ```
Serraniel commented 2020-09-04 16:08:00 +02:00 (Migrated from github.com)
Review
Copy link
        debug: isDev
```suggestion debug: isDev ```

2
src/manifests/firefox.manifest.json
View file

@ -5,7 +5,7 @@
kaffem commented 2020-09-01 16:00:54 +02:00 (Migrated from github.com)
Review
Copy link

This needs to be an object for firefox, see devDocs/manifest.json/developer otherwise it's an invalid extension.

This needs to be an object for firefox, see [devDocs/manifest.json/developer](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/developer) otherwise it's an invalid extension.
Serraniel commented 2020-09-02 15:00:19 +02:00 (Migrated from github.com)
Review
Copy link

Yeah you are correct. Somehow forgot to change this but I read it, too.

Yeah you are correct. Somehow forgot to change this but I read it, too.
Serraniel commented 2020-09-06 20:58:57 +02:00 (Migrated from github.com)
Review
Copy link

This is fixed. Manifest validation on the webstores also is working now (regarding manifest.json syntax). I will open new issues for other validation problems I noticed.

This is fixed. Manifest validation on the webstores also is working now (regarding *manifest.json* syntax). I will open new issues for other validation problems I noticed.
kaffem commented 2020-09-01 16:00:54 +02:00 (Migrated from github.com)
Review
Copy link

This needs to be an object for firefox, see devDocs/manifest.json/developer otherwise it's an invalid extension.

This needs to be an object for firefox, see [devDocs/manifest.json/developer](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/developer) otherwise it's an invalid extension.
Serraniel commented 2020-09-02 15:00:19 +02:00 (Migrated from github.com)
Review
Copy link

Yeah you are correct. Somehow forgot to change this but I read it, too.

Yeah you are correct. Somehow forgot to change this but I read it, too.
Serraniel commented 2020-09-06 20:58:57 +02:00 (Migrated from github.com)
Review
Copy link

This is fixed. Manifest validation on the webstores also is working now (regarding manifest.json syntax). I will open new issues for other validation problems I noticed.

This is fixed. Manifest validation on the webstores also is working now (regarding *manifest.json* syntax). I will open new issues for other validation problems I noticed.
"description": "$description",
"manifest_version": 2,
"author": "$author",
"developer": "$developer",
kaffem commented 2020-09-01 16:00:54 +02:00 (Migrated from github.com)
Review
Copy link

This needs to be an object for firefox, see devDocs/manifest.json/developer otherwise it's an invalid extension.

This needs to be an object for firefox, see [devDocs/manifest.json/developer](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/developer) otherwise it's an invalid extension.
Serraniel commented 2020-09-02 15:00:19 +02:00 (Migrated from github.com)
Review
Copy link

Yeah you are correct. Somehow forgot to change this but I read it, too.

Yeah you are correct. Somehow forgot to change this but I read it, too.
Serraniel commented 2020-09-06 20:58:57 +02:00 (Migrated from github.com)
Review
Copy link

This is fixed. Manifest validation on the webstores also is working now (regarding manifest.json syntax). I will open new issues for other validation problems I noticed.

This is fixed. Manifest validation on the webstores also is working now (regarding *manifest.json* syntax). I will open new issues for other validation problems I noticed.
"developer": $developer,
kaffem commented 2020-09-01 16:00:54 +02:00 (Migrated from github.com)
Review
Copy link

This needs to be an object for firefox, see devDocs/manifest.json/developer otherwise it's an invalid extension.

This needs to be an object for firefox, see [devDocs/manifest.json/developer](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/developer) otherwise it's an invalid extension.
Serraniel commented 2020-09-02 15:00:19 +02:00 (Migrated from github.com)
Review
Copy link

Yeah you are correct. Somehow forgot to change this but I read it, too.

Yeah you are correct. Somehow forgot to change this but I read it, too.
Serraniel commented 2020-09-06 20:58:57 +02:00 (Migrated from github.com)
Review
Copy link

This is fixed. Manifest validation on the webstores also is working now (regarding manifest.json syntax). I will open new issues for other validation problems I noticed.

This is fixed. Manifest validation on the webstores also is working now (regarding *manifest.json* syntax). I will open new issues for other validation problems I noticed.
"homepage_url": "$homepageURL",
"icons": {
"48": "images/icon/icon_48.png",

kaffem commented 2020-09-01 16:00:54 +02:00 (Migrated from github.com)
Review
Copy link

This needs to be an object for firefox, see devDocs/manifest.json/developer otherwise it's an invalid extension.

This needs to be an object for firefox, see [devDocs/manifest.json/developer](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/developer) otherwise it's an invalid extension.
Serraniel commented 2020-09-02 15:00:19 +02:00 (Migrated from github.com)
Review
Copy link

Yeah you are correct. Somehow forgot to change this but I read it, too.

Yeah you are correct. Somehow forgot to change this but I read it, too.
Serraniel commented 2020-09-06 20:58:57 +02:00 (Migrated from github.com)
Review
Copy link

This is fixed. Manifest validation on the webstores also is working now (regarding manifest.json syntax). I will open new issues for other validation problems I noticed.

This is fixed. Manifest validation on the webstores also is working now (regarding *manifest.json* syntax). I will open new issues for other validation problems I noticed.
kaffem commented 2020-09-01 16:00:54 +02:00 (Migrated from github.com)
Review
Copy link

This needs to be an object for firefox, see devDocs/manifest.json/developer otherwise it's an invalid extension.

This needs to be an object for firefox, see [devDocs/manifest.json/developer](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/developer) otherwise it's an invalid extension.
Serraniel commented 2020-09-02 15:00:19 +02:00 (Migrated from github.com)
Review
Copy link

Yeah you are correct. Somehow forgot to change this but I read it, too.

Yeah you are correct. Somehow forgot to change this but I read it, too.
Serraniel commented 2020-09-06 20:58:57 +02:00 (Migrated from github.com)
Review
Copy link

This is fixed. Manifest validation on the webstores also is working now (regarding manifest.json syntax). I will open new issues for other validation problems I noticed.

This is fixed. Manifest validation on the webstores also is working now (regarding *manifest.json* syntax). I will open new issues for other validation problems I noticed.

2
src/manifests/opera.manifest.json
View file

@ -6,7 +6,7 @@
"description": "$description",
"manifest_version": 2,
"author": "$author",
"developer": "$developer",
"developer": $developer,
"homepage_url": "$homepageURL",
"icons": {
"48": "images/icon/icon_48.png",