Serraniel/AniwatchPlus
Serraniel/AniwatchPlus
1
0
Fork 0
Code Issues 9 Pull requests 8 Packages Projects Releases 10 Wiki Activity

Feature/#35 build tools #36

Merged
Serraniel merged 41 commits from feature/#35-build-tools into develop 2020-09-06 21:20:03 +02:00
Conversation 0 Commits 41 Files changed 23 +4 -4
4 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 98cc32cae4 - Show all commits

2
src/manifests/chrome.manifest.json
View file

@ -18,6 +18,6 @@
"js": [ "js": [
"javascript/app.min.js" "javascript/app.min.js"
], ],
"run_at": "document_start" "run_at": "document_end"
}] }]
} }

2
src/manifests/firefox.manifest.json
View file

@ -18,6 +18,6 @@
kaffem commented 2020-09-01 16:00:54 +02:00 (Migrated from github.com)
Review
Copy link

This needs to be an object for firefox, see devDocs/manifest.json/developer otherwise it's an invalid extension.

This needs to be an object for firefox, see [devDocs/manifest.json/developer](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/developer) otherwise it's an invalid extension.
Serraniel commented 2020-09-02 15:00:19 +02:00 (Migrated from github.com)
Review
Copy link

Yeah you are correct. Somehow forgot to change this but I read it, too.

Yeah you are correct. Somehow forgot to change this but I read it, too.
Serraniel commented 2020-09-06 20:58:57 +02:00 (Migrated from github.com)
Review
Copy link

This is fixed. Manifest validation on the webstores also is working now (regarding manifest.json syntax). I will open new issues for other validation problems I noticed.

This is fixed. Manifest validation on the webstores also is working now (regarding *manifest.json* syntax). I will open new issues for other validation problems I noticed.
kaffem commented 2020-09-01 16:00:54 +02:00 (Migrated from github.com)
Review
Copy link

This needs to be an object for firefox, see devDocs/manifest.json/developer otherwise it's an invalid extension.

This needs to be an object for firefox, see [devDocs/manifest.json/developer](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/developer) otherwise it's an invalid extension.
Serraniel commented 2020-09-02 15:00:19 +02:00 (Migrated from github.com)
Review
Copy link

Yeah you are correct. Somehow forgot to change this but I read it, too.

Yeah you are correct. Somehow forgot to change this but I read it, too.
Serraniel commented 2020-09-06 20:58:57 +02:00 (Migrated from github.com)
Review
Copy link

This is fixed. Manifest validation on the webstores also is working now (regarding manifest.json syntax). I will open new issues for other validation problems I noticed.

This is fixed. Manifest validation on the webstores also is working now (regarding *manifest.json* syntax). I will open new issues for other validation problems I noticed.
"js": [ "js": [
"javascript/app.min.js" "javascript/app.min.js"
], ],
"run_at": "document_start" "run_at": "document_end"
kaffem commented 2020-09-01 16:00:54 +02:00 (Migrated from github.com)
Review
Copy link

This needs to be an object for firefox, see devDocs/manifest.json/developer otherwise it's an invalid extension.

This needs to be an object for firefox, see [devDocs/manifest.json/developer](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/developer) otherwise it's an invalid extension.
Serraniel commented 2020-09-02 15:00:19 +02:00 (Migrated from github.com)
Review
Copy link

Yeah you are correct. Somehow forgot to change this but I read it, too.

Yeah you are correct. Somehow forgot to change this but I read it, too.
Serraniel commented 2020-09-06 20:58:57 +02:00 (Migrated from github.com)
Review
Copy link

This is fixed. Manifest validation on the webstores also is working now (regarding manifest.json syntax). I will open new issues for other validation problems I noticed.

This is fixed. Manifest validation on the webstores also is working now (regarding *manifest.json* syntax). I will open new issues for other validation problems I noticed.
kaffem commented 2020-09-01 16:00:54 +02:00 (Migrated from github.com)
Review
Copy link

This needs to be an object for firefox, see devDocs/manifest.json/developer otherwise it's an invalid extension.

This needs to be an object for firefox, see [devDocs/manifest.json/developer](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/developer) otherwise it's an invalid extension.
Serraniel commented 2020-09-02 15:00:19 +02:00 (Migrated from github.com)
Review
Copy link

Yeah you are correct. Somehow forgot to change this but I read it, too.

Yeah you are correct. Somehow forgot to change this but I read it, too.
Serraniel commented 2020-09-06 20:58:57 +02:00 (Migrated from github.com)
Review
Copy link

This is fixed. Manifest validation on the webstores also is working now (regarding manifest.json syntax). I will open new issues for other validation problems I noticed.

This is fixed. Manifest validation on the webstores also is working now (regarding *manifest.json* syntax). I will open new issues for other validation problems I noticed.
}] }]
} }

2
src/manifests/manifest.template.json
View file

@ -19,6 +19,6 @@
"js": [ "js": [
"javascript/app.min.js" "javascript/app.min.js"
], ],
"run_at": "document_start" "run_at": "document_end"
}] }]
} }

2
src/manifests/opera.manifest.json
View file

@ -19,6 +19,6 @@
"js": [ "js": [
"javascript/app.min.js" "javascript/app.min.js"
], ],
"run_at": "document_start" "run_at": "document_end"
}] }]
} }