#52 Remove href attribute instead of clearing it #53

Merged

Serraniel merged 1 commit from bugfix/#52-clicking-quick-search-navigates-to-home into develop

2020-09-21 21:14:32 +02:00

Serraniel commented

2020-09-20 15:35:43 +02:00

(Migrated from github.com)

This will fix #52. The empty href-attribute made the website navigate to the home page.

This will fix #52. The empty `href`-attribute made the website navigate to the *home* page.

kaffem commented

2020-09-20 19:46:20 +02:00

(Migrated from github.com)

Works. Does this maybe generate another warning by firefox extension validation?

kaffem (Migrated from github.com) approved these changes 2020-09-20 19:46:39 +02:00

Serraniel commented

2020-09-20 19:53:57 +02:00

(Migrated from github.com)

Does this maybe generate another warning by firefox extension validation?

I don´t think so. The warnings mostly are on functions which allow to add some type of unsafe content into the page, for example by using eval or setting HTML directly.

> Does this maybe generate another warning by firefox extension validation? I don´t think so. The warnings mostly are on functions which allow to add some type of unsafe content into the page, for example by using `eval` or setting HTML directly.

kaffem commented

2020-09-21 04:01:09 +02:00

(Migrated from github.com)

Then you can go on and merge it; I see no other problems so far.