Serraniel/AniwatchPlus
Serraniel/AniwatchPlus
1
0
Fork 0
Code Issues 9 Pull requests 8 Packages Projects Releases 10 Wiki Activity

Feature/#3 better display of language icons #55

Merged
Serraniel merged 18 commits from feature/#3-better-display-of-language-icons into develop 2020-10-01 21:34:19 +02:00
Conversation 3 Commits 18 Files changed 2 +3 -5
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 7e3be1e059 - Show all commits

8
src/javascript/enhancements/languageDisplay.js
View file

@ -27,7 +27,7 @@ function updateLanguageDisplayListMode(node) {
kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```
kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```
// last column with flags
let col = node.querySelector('h3.layout-align-end-center');
if (typeof col === 'undefined' || col.eaManipulated) {
kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```
if (typeof col === 'undefined' || col.awpManipulated) {
kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```
return;
}
@ -38,9 +38,7 @@ function updateLanguageDisplayBoxMode(node) {
kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```
kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```
// last column with flags
let col = node.querySelector('div.layout-align-end-start');
console.log(col)
kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```
kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```
if (typeof col === 'undefined' || col.eaManipulated) {
kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```
if (typeof col === 'undefined' || col.awpManipulated) {
kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```
return;
}
@ -222,5 +220,5 @@ function dopUpdateLanguageDisplay(parent, isBoxedModed) {
kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```
kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```
div.style.paddingRight = '2px';
})
parent.eaManipulated = true;
kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```
parent.awpManipulated = true;
kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```
}