Serraniel/AniwatchPlus

Fork 0

Feature/#3 better display of language icons #55

Merged

Serraniel merged 18 commits from feature/#3-better-display-of-language-icons into develop

2020-10-01 21:34:19 +02:00

Serraniel commented

2020-09-27 12:51:45 +02:00

(Migrated from github.com)

Screenshots for the improvments are added into #3 .

Serraniel commented

2020-09-27 13:06:37 +02:00

(Migrated from github.com)

I just noticed that the icons below the player also are part of the issue. So this should not be merged yet. However, I think the algorithm itself hopefully will not be affected a lot so I think the current state already can be reviewed and the merge being delayed until the issue is completed.

add implementation for the player.

Serraniel commented

2020-09-27 13:52:46 +02:00

(Migrated from github.com)

Nvm, I created #58 as successor for the realignment of the language selection below the player as it is a differnt at all and would blow up the pull request with additional code for a different feature.

kaffem (Migrated from github.com) approved these changes 2020-10-01 19:41:15 +02:00

src/javascript/enhancements/languageDisplay.js

kaffem (Migrated from github.com) commented

2020-10-01 19:36:31 +02:00

    doUpdateLanguageDisplay(col, false);

```suggestion doUpdateLanguageDisplay(col, false); ```

kaffem (Migrated from github.com) commented

2020-10-01 19:37:25 +02:00

    doUpdateLanguageDisplay(col, true);

```suggestion doUpdateLanguageDisplay(col, true); ```

kaffem (Migrated from github.com) commented

2020-10-01 19:37:29 +02:00

function doUpdateLanguageDisplay(parent, isBoxedModed) {

```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```

Serraniel commented

2020-10-01 20:13:54 +02:00

(Migrated from github.com)

Applied all of the typo fixes 👌

kaffem (Migrated from github.com) approved these changes 2020-10-01 21:33:12 +02:00

No reviewers

kaffem

No labels

State: Waiting for release

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Serraniel/AniwatchPlus#55

No description provided.