Serraniel/AniwatchPlus
Serraniel/AniwatchPlus
1
0
Fork 0
Code Issues 9 Pull requests 8 Packages Projects Releases 10 Wiki Activity

Feature/#3 better display of language icons #55

Merged
Serraniel merged 18 commits from feature/#3-better-display-of-language-icons into develop 2020-10-01 21:34:19 +02:00
Conversation 3 Commits 18 Files changed 2 +2 -2
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit e4a7238921 - Show all commits

4
src/javascript/enhancements/languageDisplay.js
View file

@ -33,7 +33,7 @@ function updateLanguageDisplay(node) {
kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```
kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```
let dubs = [];
// find subs
subCols = col.querySelectorAll('[ng-hide*="sub"]');
kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```
let subCols = col.querySelectorAll('[ng-hide*="sub"]');
kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```
subCols.forEach(element => {
let langAttr = element.attributes['ng-hide'].value;
let lang = langAttr.substring(langAttr.indexOf(langPrefix) + langPrefix.length, langAttr.indexOf(subSuffix));
@ -43,7 +43,7 @@ function updateLanguageDisplay(node) {
kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```
kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```
});
// find dubs
dubCols = col.querySelectorAll('[ng-hide*="dub"]');
kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```
let dubCols = col.querySelectorAll('[ng-hide*="dub"]');
kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```
dubCols.forEach(element => {
let langAttr = element.attributes['ng-hide'].value;
let lang = langAttr.substring(langAttr.indexOf(langPrefix) + langPrefix.length, langAttr.indexOf(dubSuffix));

kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```
kaffem commented 2020-10-01 19:36:31 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, false);
```suggestion doUpdateLanguageDisplay(col, false); ```
kaffem commented 2020-10-01 19:37:25 +02:00 (Migrated from github.com)
Review
Copy link
    doUpdateLanguageDisplay(col, true);
```suggestion doUpdateLanguageDisplay(col, true); ```
kaffem commented 2020-10-01 19:37:29 +02:00 (Migrated from github.com)
Review
Copy link
function doUpdateLanguageDisplay(parent, isBoxedModed) {
```suggestion function doUpdateLanguageDisplay(parent, isBoxedModed) { ```