Feature/#91 watch2gether display chat message character count #93

Merged
Serraniel merged 12 commits from feature/#91-watch2gether-display-chat-message-character-count into develop 2020-10-29 18:09:12 +01:00
Serraniel commented 2020-10-25 13:56:01 +01:00 (Migrated from github.com)

2020-10-28_22-34-46-630

![2020-10-28_22-34-46-630](https://user-images.githubusercontent.com/8461282/97499420-19825180-196e-11eb-8508-32aed1867a4a.gif)
Serraniel (Migrated from github.com) reviewed 2020-10-25 18:52:30 +01:00
@ -0,0 +3,4 @@
import { v4 as uuidv4 } from 'uuid';
export function init() {
// UPS // runAfterLoad is not what we want...wait for runAfterLocationChange....
Serraniel (Migrated from github.com) commented 2020-10-25 14:00:01 +01:00
  • This is blocked until the changes made in #19 are merged.

However, the rest of the changes should be ready for a first review. But it may be possible this code doesn´t work yet as I cannot test it in the current state.

- [x] This is blocked until the changes made in #19 are merged. However, the rest of the changes should be ready for a first review. But it may be possible this code doesn´t work yet as I cannot test it in the current state.
Serraniel (Migrated from github.com) reviewed 2020-10-28 22:36:42 +01:00
@ -0,0 +3,4 @@
import { v4 as uuidv4 } from 'uuid';
export function init() {
// UPS // runAfterLoad is not what we want...wait for runAfterLocationChange....
Serraniel (Migrated from github.com) commented 2020-10-28 22:36:42 +01:00

Blocking item was merges.

Blocking item was merges.
Serraniel commented 2020-10-28 22:38:21 +01:00 (Migrated from github.com)

@kaffem I added a gif into the original description. Do you think the animation is too fast? Please keep in mind that some frames may be missing because of the recording settings.

@kaffem I added a gif into the original description. Do you think the animation is too fast? Please keep in mind that some frames may be missing because of the recording settings.
Serraniel (Migrated from github.com) reviewed 2020-10-28 22:39:04 +01:00
Serraniel (Migrated from github.com) commented 2020-10-28 22:39:04 +01:00
notifications();
quickSearch();

wooops

```suggestion notifications(); quickSearch(); ``` wooops
kaffem (Migrated from github.com) approved these changes 2020-10-28 23:57:12 +01:00
kaffem (Migrated from github.com) left a comment

@Serraniel I tried it in my browser, just in case some frames went missing, imo it is not too fast.

@Serraniel I tried it in my browser, just in case some frames went missing, imo it is not too fast.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Serraniel/AniwatchPlus#93
No description provided.